Issue #32: Add support for SSL certificate management. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…certs in get_ssl_certs(), not the raw response.
pmatias
requested changes
Feb 1, 2021
There was a problem hiding this comment.
Hi @jlfranklin, thanks so much for your contrib!
Do you mind taking a look at the comments in the code, and, if possible, add the automated tests for the new methods?
Thanks!
acapi2/resources/environment.py
Outdated
|
|
||
| return response.json().get('_embedded', {}).get('items') | ||
|
|
||
| def get_ssl_cert(self, cert_id) -> dict: |
There was a problem hiding this comment.
I think you forgot the type hint here for cert_id :)
acapi2/resources/environment.py
Outdated
|
|
||
| return response | ||
|
|
||
| def delete_ssl_cert(self, cert_id) -> Session: |
acapi2/resources/environment.py
Outdated
|
|
||
| return response | ||
|
|
||
| def activate_ssl_cert(self, cert_id) -> Session: |
acapi2/resources/environment.py
Outdated
|
|
||
| return response | ||
|
|
||
| def deactivate_ssl_cert(self, cert_id) -> Session: |
|
Type-hinting I can do now. Automated tests will have to wait until I have a block of time to devote to it. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the following endpoints:
get_ssl_settings(): /environments/{environment_uuid}/sslget_ssl_certs(): /environments/{environment_uuid}/ssl/certificatesget_ssl_cert(): /environments/{environment_uuid}/ssl/certificates/{cert_id}install_ssl_cert(): /environments/{environment_uuid}/ssl/certificates (POST)delete_ssl_cert(): /environments/{environment_uuid}/ssl/certificates/{cert_id} (DELETE)activate_ssl_cert(): /environments/{environment_uuid}/ssl/certificates/{cert_id}/actions/activate (POST)deactivate_ssl_cert(): /environments/{environment_uuid}/ssl/certificates/{cert_id}/actions/deactivate (POST)